Closed arashsheyda closed 4 months ago
Impressive! Give me some time to review hahah I promise I won't leave you hanging
@MandyMeindersma Sure, take your time. thanks :)
(most of the code change is for package-lock.json
hahaha, I didn't do that much)
Also it looks like you might have some prettify errors? I think that's why the build failed
@MandyMeindersma yes the build error is related to typescript usage + setup script (e.g. it's saying to import composables but Nuxt do that automatically). we need to re-configure eslint I guess
What issue is this referencing?
close #311
Do these code changes work locally and have you tested that they fix the issue yourself?
Does the following command run without warnings or errors?
npm run pr-checks
it gives some errors related to typescript usage (e.g. it saying to import composables but Nuxt do that automatically). I would need help on this :)
Have you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use
?Descriptions
some description about changes:
Modules
so I added this modules:
@nuxt/content
for managing content@nuxtjs/seo
for SEO (I didn't add ogImage supprot so others can contribute)nuxt-icon
for icons (it has all the icons from iconify. you can check the icons list here) I didn't change other icons (svg codes) so other may contributePages
content
directory.[...slug]
was added so it can catch any path fromcontent
.Components
App
directory is for local components to be used inpages
or other components. (they are not accessible fromcontent
directory)cotnent
is for@nuxt/content
override componentssection
is global components that can be accessed fromcontent
or any.vue
file.also removed the components that are no longer used.
Utils
changed
utilities
toutils
as nuxt does auto-import files fromutils
Suggestions
here are some modules that I think can be removed or replaced:
@nuxtjs/google-analytics
: this module is for Nuxt 2, for Nuxt 3 we have to use GTag@nuxtjs/pwa
: is for Nuxt 2, we have to use vite-pwaeslint...
: we can migrate to@nuxt/eslint-config
so some extra packages can be removedit would be great to convert all the components that are
option-api
tocomposition-api
as vue 2 is deprecated now.Nuxt & Vue have full typescript support and it would be better if we used TS as well :)
tests
can be updatedit would be great to keep dependencies updated. we can configure renovate maybe
thanks!