devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
22 stars 52 forks source link

set fixed width on button with responsive adjustment #330

Closed jsc215 closed 3 months ago

jsc215 commented 4 months ago

What issue is this referencing?

this fixes #321

Do these code changes work locally and have you tested that they fix the issue yourself?

Does the following command run without warnings or errors?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

MandyMeindersma commented 4 months ago

Thanks so much @jsc215 ! I love it.

I think we must have configured our linter weird, so I want to try to change it before we merge this in (we just changed to a new linting method, thank you for being our guinea pig). Unless this is your editors linting?

I am not on my machine until Tuesday though (going to view the eclipse! 🌞 ) so it might be until then until I can debug. Sorry!

arashsheyda commented 4 months ago

@jsc215 great work, thanks!

@MandyMeindersma the stylistic of eslint module is false by default (I thought it was true by default, sorry) I'll open a PR asap and after that we can merge this PR.

jsc215 commented 4 months ago

@jsc215 great work, thanks!

@MandyMeindersma the stylistic of eslint module is false by default (I thought it was true by default, sorry) I'll open a PR asap and after that we can merge this PR.

you're very welcome!

MandyMeindersma commented 4 months ago

Thanks to @arashsheyda our linting should be fixed now!

I think if you run npm run lint:fix it should auto fix? but if now maybe copy your changes to a new branch! Thanks again for being our guinea pig @jsc215

MandyMeindersma commented 3 months ago

Hey @jsc215 I would still love to have your contribution so if you want to run the linting command that would be great, other wise I will merge this into another branch and then commit the linting errors then merge that (that way we still have your commit and work recorded!) 😄

MandyMeindersma commented 3 months ago

@arashsheyda saved us again with the auto linting bot! Thank you

@allcontributors add @jsc215 for code

allcontributors[bot] commented 3 months ago

@MandyMeindersma

I've put up a pull request to add @jsc215! :tada: