devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
22 stars 52 forks source link

feat: use different colors on text selection/highlight dark/light mode #338

Closed yaroslavhoretskyi closed 2 months ago

yaroslavhoretskyi commented 3 months ago

Light Mode (old):

image

(new)

image

Dark Mode:

image
yaroslavhoretskyi commented 3 months ago

I love it, I'll add it!

MandyMeindersma commented 3 months ago

Oh sorry @yaroslavhoretskyi I wasn't talking about the colour.

I was talking about the opacity. Like how the "G"s aren't cut off, you know what I mean?

image

image

My guess is that you would have to use a rgb(#,#,#,0.5) method to get it to work but maybe ask around tonight to see if someone else has a better idea.

dgmouris commented 3 months ago

Sorry I updated this branch while I was reading it!

MandyMeindersma commented 3 months ago

@yaroslavhoretskyi I wanted to check in to see if you still wanted to give tis a shot :)

If you have any questions, let me know :)

yaroslavhoretskyi commented 2 months ago

@MandyMeindersma, thanks for the ping, I just got lost in all the messages in my email.. I'd like to finish.

MandyMeindersma commented 2 months ago

Absolutely! No rush :)

arashsheyda commented 2 months ago

@yaroslavhoretskyi can you exclude the package.json from the PR? thanks

MandyMeindersma commented 2 months ago

Weird @yaroslavhoretskyi the package files are still showing for me.

It almost looks like the bot is kind of readding stuff since there is a change on that file. I wonder if there is a way to remove all your changes from the file?

Or honestly copy and paste your changes to another branch ahhaha

MandyMeindersma commented 2 months ago

349

Sorry 😢

MandyMeindersma commented 2 months ago

Thank you so much @yaroslavhoretskyi !!!

Sorry there were bot issues! I have turned off the bot so that won't happen again!

Thank you so much for making the website better!

MandyMeindersma commented 2 months ago

@allcontributors add @yaroslavhoretskyi for code

allcontributors[bot] commented 2 months ago

@MandyMeindersma

@yaroslavhoretskyi already contributed before to code