search

devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
22 stars 52 forks source link

Resolved #326 #359

Closed atridadl closed 1 month ago

atridadl commented 1 month ago

What issue is this referencing?

This PR resolved #326

Do these code changes work locally and have you tested that they fix the issue yourself?

Does the following command run without warnings or errors?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

arashsheyda commented 1 month ago

@atridadl great work! also could you add :loop="true" so it's looped. thanks

atridadl commented 1 month ago

@atridadl great work! also could you add :loop="true" so it's looped. thanks

Absolutely. Adding it now. Noticed that (at least locally) it looped without that. That being said, this can't hurt either.

arashsheyda commented 1 month ago

thanks! the loop property adds a loop functionality when you try to swipe manually

MandyMeindersma commented 1 month ago

Probably the fastest code review I have ever seen in my life hahahah great job

MandyMeindersma commented 1 month ago

@allcontributors add @atridadl for code

allcontributors[bot] commented 1 month ago

@MandyMeindersma

I've put up a pull request to add @atridadl! :tada: