search

devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
29 stars 78 forks source link

add [lang] attribute to html element #417

Closed arashsheyda closed 3 weeks ago

arashsheyda commented 1 month ago

this is an a11y issue, we need to add [lang] attribute to html element.

tylersocholotuik commented 3 weeks ago

Hello, I believe I have fixed this issue, but I get this error when running es lint:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.3

Please only submit bug reports when using the officially supported version.

All of the other tests pass, however.

Here is a screenshot showing the html element

html-lang

Please let me know if I can submit a PR, or if you would like me to solve the issue with es lint first. This is my first issue, so I want to make sure everything is good before submitting. Thanks in advance.

arashsheyda commented 3 weeks ago

hey @tylersocholotuik , yeah don't worry about that you can submit a PR 😃 thanks!

tylersocholotuik commented 3 weeks ago

hey @tylersocholotuik , yeah don't worry about that you can submit a PR 😃 thanks!

Submitted, thank you!