My node version matches the one suggested when running nvm use?
[x] yes!
What happened
Events that don't have a time use the date field instead of the dateTime field. Originally these weren't showing up on the calendar and it was fixed by using an OR to check for the usage of date field. This worked to make them appear but it create more issues such as start and end time being defaulted and equal to each other. And the end date wasn't correct.
These new changes forcibly add a time onto the date time. Those two issues are now fixed. Future changes could potentially be made to just hide the time for events that are all day or don't have a start and end time but this remove a lot of weirdness and the bugs with the calendar.
Screenshots
You can see in this screenshot that the end date for DevelopEd Hackathon is now correctly on the 11th.
The start date and end date now stretch the full day.
MandyMeindersma
commented
1 month ago
What issue is this referencing?
This PR further improves and fixes #418
Do these code changes work locally and have you tested that they fix the issue yourself?
Does the following command run without warnings or errors?
npm run pr-checksHave you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use?What happened
Events that don't have a time use the date field instead of the dateTime field. Originally these weren't showing up on the calendar and it was fixed by using an OR to check for the usage of date field. This worked to make them appear but it create more issues such as start and end time being defaulted and equal to each other. And the end date wasn't correct.
These new changes forcibly add a time onto the date time. Those two issues are now fixed. Future changes could potentially be made to just hide the time for events that are all day or don't have a start and end time but this remove a lot of weirdness and the bugs with the calendar.
Screenshots
You can see in this screenshot that the end date for DevelopEd Hackathon is now correctly on the 11th.
The start date and end date now stretch the full day.