search

devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
29 stars 78 forks source link

chore: UI improvments #436

Closed arashsheyda closed 4 weeks ago

arashsheyda commented 1 month ago

What issue is this referencing?

this PR improves the couloring in dark mode, and fixes some minor UI problems (sorry it kinda got into me, I didn't open an issue first)

Before After
Screenshot 2024-10-24 at 8 36 43 PM Screenshot 2024-10-24 at 8 37 04 PM

Do these code changes work locally and have you tested that they fix the issue yourself?

Does the following command run without warnings or errors?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

arashsheyda commented 1 month ago

thanks @dgmouris

johnjovero98 commented 1 month ago

I really like the detail of putting the "Dev Edmonton Society" on that purple chip!

Suggestion: I would recolor the button on light mode

before after
Screenshot 2024-10-25 at 1 40 22 PM Screenshot 2024-10-25 at 1 37 35 PM

(frontend and UX/UI talks, amiright 👀)

arashsheyda commented 1 month ago

@johnjovero98 nice catch! will do, thanks

MandyMeindersma commented 4 weeks ago

LOVE