search

devedmonton / DES-Website

The Dev Edmonton Society website! We empower Edmonton Developers!
https://devedmonton.com
MIT License
29 stars 78 forks source link

Fix #417 Added html lang attribute #442

Closed tylersocholotuik closed 3 weeks ago

tylersocholotuik commented 3 weeks ago

What issue is this referencing?

417

html-lang

Do these code changes work locally and have you tested that they fix the issue yourself?

Does the following command run without warnings or errors?

Have you taken a look at our contributing guidelines?

My node version matches the one suggested when running nvm use?

DerrykBoyd commented 3 weeks ago

LGTM! but I'm not sure if we should use en or en_CA \cc @MandyMeindersma @DerrykBoyd @dgmouris

I think the correct format is en-CA (hyphen separated) but yes I would vote for that

tylersocholotuik commented 3 weeks ago

LGTM! but I'm not sure if we should use en or en_CA \cc @MandyMeindersma @DerrykBoyd @dgmouris

I think the correct format is en-CA (hyphen separated) but yes I would vote for that

If I make the change to en-CA, do I need to make a new pull request, or can I simply edit the file in this PR? I apologize, I am very new to this.

DerrykBoyd commented 3 weeks ago

LGTM! but I'm not sure if we should use en or en_CA \cc @MandyMeindersma @DerrykBoyd @dgmouris

I think the correct format is en-CA (hyphen separated) but yes I would vote for that

If I make the change to en-CA, do I need to make a new pull request, or can I simply edit the file in this PR? I apologize, I am very new to this.

You can for sure edit the file in this PR @tylersocholotuik thanks!

tylersocholotuik commented 3 weeks ago

Ok, I made the change to en-CA. Thanks for the tips!

arashsheyda commented 3 weeks ago

thanks @tylersocholotuik

@allcontributors add @tylersocholotuik for code

allcontributors[bot] commented 3 weeks ago

@arashsheyda

I've put up a pull request to add @tylersocholotuik! :tada: