develar / 7zip-bin

7-Zip precompiled binaries
MIT License
117 stars 34 forks source link

Add native Windows arm64 binary #13

Closed dennisameling closed 2 years ago

dennisameling commented 3 years ago

I'm building https://github.com/signalapp/signal-desktop for Windows arm64, but the release script is failing due to no arm64 7za.exe binary being available for Windows:

⨯ cannot execute  cause=exec: "C:\\actions-runner\\_work\\signal-desktop-silicon\\signal-desktop-silicon\\node_modules\\7zip-bin\\win\\arm64\\7za.exe": file does not exist

This PR adds the missing binary.

I built the arm64 version as follows:

Can confirm this works on my arm64 device when compiling Signal Desktop.

Even though Windows arm64 can run ia32 executables through emulation, the native arm64 version is ~45% faster:

~33s on arm64 native
~48s on ia32 through emulation

 • building        target=nsis file=release\signal-desktop-win-5.3.0-beta.2.exe archs=arm64 oneClick=true perMachine=false
dennisameling commented 2 years ago

Hi @develar, just wanted to bring this to your attention. Would appreciate if you could have a look at this PR - happy to help/provide context or info if needed. Thanks in advance!