develop-me / bagajob

Job Hunting Management App built by Develop Me students for Develop Me students.
https://bagajob.developme.space
GNU Affero General Public License v3.0
1 stars 2 forks source link

User account page and auth functionality #42

Closed aejgardner closed 3 years ago

aejgardner commented 4 years ago
kierancott commented 4 years ago

Updated Issues

Account registration - error handling, Issue https://github.com/develop-me/bagajob/issues/43

Action:

Result:

Instead of the app crashing due to unprocessable entity, the below error is shown:

Screenshot 2020-09-19 at 15 28 08

Login, Issue https://github.com/develop-me/bagajob/issues/44

Action:

Bearer token has been added to the header of the request.

Result:

200 - OK: API now approves access and loads main page with code 200.

Screenshot 2020-09-18 at 17 57 40

Reset Password, Issue https://github.com/develop-me/bagajob/issues/45

Commit: https://github.com/develop-me/bagajob/commit/201f10d8c076628ff3c3c7c042550c7c56917daf

Action:

Result:

Feedback is given to user while loading, and when email is sent - instructing them to check their inbox.

Screenshot 2020-09-20 at 17 58 56

Reset password (with token), Issue https://github.com/develop-me/bagajob/issues/46

Commit: https://github.com/develop-me/bagajob/pull/42/commits/55630843d1a5c240161331762018bed7dedafe9a

Action:

Result:

Screenshot 2020-09-21 at 15 33 19

Other issues resolved by this Pull Request:

Logout functionality, Issue https://github.com/develop-me/bagajob/issues/49

Commits https://github.com/develop-me/bagajob/pull/42/commits/3a0938cecb37a54388c621b722b3193f2eb3ef7d https://github.com/develop-me/bagajob/pull/42/commits/fe2857b9a0d84667a245b30efaa334e02709c9cb

Action:

Result:

Visiting api/home/logout and clicking "Log Out" now clears state and prompts user to return to login

Screenshot 2020-09-19 at 17 30 20 Screenshot 2020-09-19 at 17 42 07

More styling still required.

Single job - user ID undefined, Issue https://github.com/develop-me/bagajob/issues/50

Commit https://github.com/develop-me/bagajob/pull/42/commits/ee491d805cecd146b292fd2ccf8327c06a1dfc17, https://github.com/develop-me/bagajob/pull/42/commits/e09682b977347eefbc961bd925a35025ee07e000

Action:

Result:

422 - Unprocessable Entity : API is no longer returning an authorisation error. Bearer token correctly used in header.

Screenshot 2020-09-19 at 00 28 33

kierancott commented 3 years ago

Closed in error.

kierancott commented 3 years ago

Updated Issues

- General feedback - the errors displayed to the User in the front end should be non-programmery, so no mention of status codes, etc. - could be a good one to give to a new person and probably not necessary to fix for MVP since we're short on time.

Moved to separate issue for a later date post-MVP (Issue https://github.com/develop-me/bagajob/issues/55)

- Issue #43 - see issue

Now resolved Commit https://github.com/develop-me/bagajob/pull/42/commits/b68f7d7c0eec210c3aa2d5f9e91c14a6db8006e8

- #46 When resetting password Client doesn't seem to send token, email, password to server.

(Issue https://github.com/develop-me/bagajob/issues/46) Email, token and password now being correctly sent and backend returns 200 OK. Commit https://github.com/develop-me/bagajob/pull/42/commits/b68f7d7c0eec210c3aa2d5f9e91c14a6db8006e8

- When I enter an incorrect password on logging in, I see the error on the screen for a short period then it bombs out:

Now resolved Commit https://github.com/develop-me/bagajob/pull/42/commits/b68f7d7c0eec210c3aa2d5f9e91c14a6db8006e8

- When I get through adding a new job, the post request is bombing out because active and stage are not being sent in the POST request

Now resolved, active and stage are included in the POST request. Commit https://github.com/develop-me/bagajob/pull/42/commits/bc52e8dc009e03c547dc4596b15eba7a53c89212

NB - An issue still remains with this route that would require your attention: https://github.com/develop-me/bagajob-API/issues/23

kierancott commented 3 years ago

Updated Issues

image

When I register a new user, the POST route for registration works fine, however the Client then makes a GET request for UserID 5's jobs and bombs out... my guess is that state is not getting updated with the User sent back from the backend on successful registration. You might not be seeing it if you're staying in the same browser session and not fully clearing state before trying registration again.


Resolution:

Commit https://github.com/develop-me/bagajob/pull/42/commits/9cfcb733717c7c4645573477277570941f1d09b9

When a POST request is made to /register, the bearer token is included in the header, results in status 200 OK when redirected to GET /user/:id/jobs

Screenshot 2020-09-22 at 16 07 24 Screenshot 2020-09-22 at 16 07 30
nosvalds commented 3 years ago

To Do

kierancott commented 3 years ago

Update:

Screenshot 2020-09-23 at 15 31 52
kierancott commented 3 years ago

Update: