develop-me / bagajob

Job Hunting Management App built by Develop Me students for Develop Me students.
https://bagajob.developme.space
GNU Affero General Public License v3.0
1 stars 2 forks source link

Interviews - When leaving blank on initial job entry, it should not make a POST request #56

Open nosvalds opened 4 years ago

nosvalds commented 4 years ago

Describe the bug When going through adding a job, the final step is to add interview notes (if you've had one). The form says you can leave it blank if you haven't. However if you do leave it blank the client still makes a POST request to the interviews route and recieves a 422 error.

To Reproduce Steps to reproduce the behavior:

  1. Login
  2. Add Job
  3. Fill out info on first 2 forms
  4. Leave interviews form blank and click finish + save
  5. Look at Dev Tools

Expected behavior I would expect the client not to make the POST request if the interview form is left blank by the user

Screenshots

image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context NOTE: This probably doesn't need to be fixed for MVP

kierancott commented 4 years ago

Issue closed in error.

Whilst this has been resolved on the "add a job form", this issue still persists on the "edit single job page".