Display and edit jobs

[kierancott]

Changelog:

• Can now add a job to database using add a job form
• Can now add interviews and application notes to that job on the same page
• Can now modify job details from single job page
• Can now modify CV and cover letter from single job page
• Can now add, edit and delete application notes from single job page
• Can now add, edit and delete interviews from single job page
• Can now delete a job
• Can now update stage using stage tracker on main page

[kierancott]

Updated

Issue: "When I click the "Add Interview" button the POST request is triggered right away. I don't see a place where I can add in interview information to be POST'd. Additionally the API Key is not included in the header so I get an unauthenticated response"

Action: Created a form that dispatches a POST request to api/users/id/jobs/id/interviews with new interview data

<img width="896" alt="Screenshot 2020-10-08 at 16 45 45" src="https://user-images.githubusercontent.com/52701889/95483938-bf522a00-0987-11eb-89b8-b81ff3c68d67.png">

---

Issue: "When I am in the edit single job page, there isn't a clear way to navigate back to the /mainpage. Looks like you can got to Account > My Applications - happy to leave this for MVP, but could add a button somewhere"

Action: Added a button that directs back to the main page - will need to be styled with CSS so that it is not right next to the delete job button

---

Issue: "Clicking to advance the green application stage indicators works visually, but I don't see any PATCH requests to the backend to change the stage value"

Action: Wrapped the status circle in a <div> that handles the colour change, the status circle itself sends a patch request. The <div> wrapper itself will need to be styled such that you cannot click the <div> without also clicking the status circle, which is currently not the case.

However, clicking the status circle itself now changes the colour, and sends a patch request for the correct job_id.

[kierancott]

Updated:

Issue: If I add an interview but don't change the "format" drop down the client doesn't include the format in the POST request and fails

Action: Added default values in initial state to be sent if any fields left blank.

Behaviour upon submitting a blank form:

---

Issue: DELETE interview is failing as Unauthorized

Action:

• Modified promise to no longer return null
• Added access_token to request header
• Modified reducer to correctly parse payload data - results in interviews deleting successfully without page refresh

[kierancott]

Updated

I've changed all components to use state.user_id rather than state.user.user.id, because the user: { ... } object changes structure whereas user_id will remain constant.

Since I've changed all the instances of state.user.user.id to state.user_id, not just the StageTracker.js, this should stop this type of error across the whole app.

Thanks for your thorough testing, let me know if you find any more pesky bugs.

[nosvalds]

New issues

From our Slack discussion

• Adding a new Job - if you leave the first form blank it fails to create a job because we have (title, company, active, stage) required on the backend. I would make "Title" and "Company" required in that form's HTML. I think that would be simplest and is reasonable to expect they filled out that much at least.
• Adding new Job - When you leave Application Notes or Interviews blank the front end should not make a POST request

[kierancott]

Updated:

• Added form validation for title and company field on job form. User cannot proceed to next step without filling in these fields.

• Added conditions to the three requests that are sent upon submission of the add job form.
  1. Application Notes: will not POST to api/user/id/jobs/id/app-notes if the data property is blank.
  2. Interviews: will note POST to api/user/id/jobs/id/interviews if the date property is blank
  3. CV/Cover Letter: will not PATCH to api/user/id/jobs/id/interviews if both the cv and cover_letter are blank (but it will if one of them is left blank).

[nosvalds]

APPROVED

[kierancott]

Post-Approval Update:

Thanks, Nik. Just a quick fix to a small issue that fell through the cracks:

Issue: Sending both CV and cover letter, or neither, works - but if you send only one, the API returns Error 422 because the API does not accept an empty string for either value.

Action: Added conditions to the form submission function, that will exclude the CV or Cover letter from the PATCH request if it is left blank