search

developer-delta / halogen

A web based application to add better lighting to video calls.
MIT License
4 stars 11 forks source link

#139 - Created Login modal UI #153

Closed Hanna-N9 closed 3 years ago

Hanna-N9 commented 3 years ago

Since I installed react-modal, I learned that it has its style prop since making changes in the className for modal doesn't work very effectively, possibly because of its style prop. So, no surprise when looking through my PR.

I used position: fixed to cover footer since position: absolute doesn't cover it. Hence, I didn't check the fourth task of using position: absolute in the Login/Sign up modal UI issue.

What it looks like: 71311170-89A4-47B0-86DF-EAED626D739E_1_105_c

mikelbrierly commented 3 years ago

Fantastic work!! Great attention to detail, I love it. Just leaving a comment on the structure