search

developer-diganta / Dino

Dino is a chrome extension to help people with dyslexia and color blindness access web pages with more ease.
MIT License
38 stars 55 forks source link

put 3 buttons of font style per row #127

Closed Harikaraja closed 1 year ago

Harikaraja commented 1 year ago

issue number : #123

Harikaraja commented 1 year ago

Good afternoon sir,

Are you saying that all the buttons must be aligned in a single row.

On Sat, 28 Jan 2023, 12:51 Diganta Kr Banik, @.***> wrote:

@.**** requested changes on this pull request.

[image: image] https://user-images.githubusercontent.com/65999534/215252852-6ff7767a-9522-43fb-8ceb-c80ba45ca3d0.png The font style buttons still overflow. I would suggest using flexbox or grid layout to make sure overflow does not happen. Also please update the PR description using the template provided. It is essential to get your score. And please remove the .vscode from your PR. Do ask if you have any doubts.

— Reply to this email directly, view it on GitHub https://github.com/developer-diganta/Dino/pull/127#pullrequestreview-1273837030, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCQWHSNOCLZFWGYMW4QIZTWUTCHXANCNFSM6AAAAAAUIODJZ4 . You are receiving this because you authored the thread.Message ID: @.***>

developer-diganta commented 1 year ago

No, it should be 3 per row. But if you see the screenshot, the 3rd buttons are not visible completely. That's why I suggested flex-box or grid, then you don't have to worry about hardcoding size values.

Harikaraja commented 1 year ago

Sir actually in my laptop screen i am able to see all the buttons clearly .can you tell me the screen width you are viewing so that I can look into that

On Sat, 28 Jan 2023, 13:04 Diganta Kr Banik, @.***> wrote:

No, it should be 3 per row. But if you see the screenshot, the 3rd buttons are not visible completely. That's why I suggested flex-box or grid, then you don't have to worry about hardcoding size values.

— Reply to this email directly, view it on GitHub https://github.com/developer-diganta/Dino/pull/127#issuecomment-1407319733, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCQWHUKOFTS4XPK4JGA23LWUTDYBANCNFSM6AAAAAAUIODJZ4 . You are receiving this because you authored the thread.Message ID: @.***>

developer-diganta commented 1 year ago

Yup that is the problem I am saying. It won't be possible for you to make sure you hardcode it for every screen width. Try using %s to make sure you get it. My screen's resolution is 1920 X 1080.

Harikaraja commented 1 year ago

Ok sir

On Sat, 28 Jan 2023, 13:12 Diganta Kr Banik, @.***> wrote:

Yup that is the problem I am saying. It won't be possible for you to make sure you hardcode it for every screen width. Try using %s to make sure you get it. My resolution is 1920 X 1080.

— Reply to this email directly, view it on GitHub https://github.com/developer-diganta/Dino/pull/127#issuecomment-1407321212, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATCQWHXDJFDRPEBPUW73543WUTEXXANCNFSM6AAAAAAUIODJZ4 . You are receiving this because you authored the thread.Message ID: @.***>