search

developer-portal / content

Content for the Fedora Developer Portal
https://developer.fedoraproject.org/
GNU General Public License v2.0
106 stars 250 forks source link

Release is pending #317

Closed tmds closed 5 years ago

tmds commented 5 years ago

@pvalena it looks like https://github.com/developer-portal/content/pull/302 changes (merged 8 March) are not visible on https://developer.fedoraproject.org/tech/languages/dotnet/about.html?

The left hand menu should say '.NET Core' as the second item and link to a page named 'dotnetcore.html' (content from https://github.com/developer-portal/content/blob/master/tech/languages/dotnet/dotnetcore.md).

pvalena commented 5 years ago

You're right. The website is on manual release schedule and I did not get around to make a release... And noone else is around to do+review it :) .. If I do a [staging] build, will you be able to take a look on / review the changes?

Note: quite often the updates are made by unexperienced contributors and the page may render in Jekyll differently to how they've expected; so it has to be fixed.

RheaAyase commented 5 years ago

@pvalena Hi, we can review our changes / pages, but I can't talk about the other PR's that were merged and will need reviewing... We could collect all the people who submitted these and ask them for review of the staging though! If you need some help with it please feel free to ping me =)

pvalena commented 5 years ago

@RheaAyase, sure, I'll build it then for staging ASAP.

It's not about the content correctness though, as that has been reviewed already in the PR. It's just a "sanity" and "styling" check - whether the page is and "looks" ok; and changes are propagated correctly (the content is there).

That means there are two things to check: git diff (master branch) and the resulting generated page (on staging).

I'll post here when it's done.

pvalena commented 5 years ago

@tmds, @RheaAyase, et al., I've just prepared release on staging:

Please review, and +1 here if you did find everything ok.

Specific links to files changed (some might've been deleted): https://developer.stg.fedoraproject.org/start/sw/web-app/laravel5.html https://developer.stg.fedoraproject.org/tech/database/mongodb/about.html https://developer.stg.fedoraproject.org/tech/database/sqlite/about.html https://developer.stg.fedoraproject.org/tech/languages/c/gtk.html https://developer.stg.fedoraproject.org/tech/languages/csharp/dotnet-installation.html https://developer.stg.fedoraproject.org/tech/languages/dotnet/about.html https://developer.stg.fedoraproject.org/tech/languages/dotnet/dotnet-ide.html https://developer.stg.fedoraproject.org/tech/languages/dotnet/dotnet-sig.html https://developer.stg.fedoraproject.org/tech/languages/dotnet/dotnet.html https://developer.stg.fedoraproject.org/tech/languages/dotnet/dotnetcore.html https://developer.stg.fedoraproject.org/tech/languages/dotnet/mono-sig.html https://developer.stg.fedoraproject.org/tech/languages/dotnet/mono.html https://developer.stg.fedoraproject.org/tech/languages/gjs/gjs-installation.html https://developer.stg.fedoraproject.org/tech/languages/go/go-programs.html https://developer.stg.fedoraproject.org/tech/languages/haskell/haskell-installation.html https://developer.stg.fedoraproject.org/tech/languages/python/multiple-pythons.html https://developer.stg.fedoraproject.org/tech/languages/ruby/ruby-installation.html

tmds commented 5 years ago

lgtm, thanks!

pvalena commented 5 years ago

Lets merge it then.

pvalena commented 5 years ago

I'll open a new issue for next release and link it here. In the meantime, grab a pull request and review it!