developer-portal / content

Content for the Fedora Developer Portal
https://developer.fedoraproject.org/
GNU General Public License v2.0
106 stars 250 forks source link

Add quick start guide for the R language #374

Closed Enchufa2 closed 3 years ago

Enchufa2 commented 3 years ago

Tested with the docker image, looks good. The R logo is missing though, not sure whether there's a place for it here in this repo or somewhere else.

Closes #330.

Enchufa2 commented 3 years ago

Here's the logo in high resolution PNG and SVG, as well as the license (CC-BY-SA 4.0 or GPL-2).

pvalena commented 3 years ago

Here's the logo in high resolution PNG and SVG, as well as the license (CC-BY-SA 4.0 or GPL-2).

Could you add that into our website repo?

Enchufa2 commented 3 years ago

Thanks for all the feedback, most changes done. I disagree in a couple of points though. See my reponses.

pvalena commented 3 years ago

Thanks for all the feedback, most changes done. I disagree in a couple of points though. See my reponses.

I'm glad you do! I'm not always right :) (and I may lack some information or overlook it). I've replied hopefully your every response (I've received way to manny commit notifications), and I'll look into the changed page some time later.

Thanks once more for a great PR!

Enchufa2 commented 3 years ago

Apologies for the flood of commits, but it was easier for me to commit and resolve, as it was also a flood of comments. ;-)

So (if I didn't miss anything) there's only one thing left: the repoquery command.

pvalena commented 3 years ago

Apologies for the flood of commits, but it was easier for me to commit and resolve, as it was also a flood of comments. ;-)

Np, but please squash them next time (or push all at once? Would solve that). I'd also prefer the commits squashed anyway, but as it's a new page/pages, I squash it into one commit in the WebUI.

So (if I didn't miss anything) there's only one thing left: the repoquery command.

Ok, I'll look into that later on.

Enchufa2 commented 3 years ago

Squashed into a single commit.

Enchufa2 commented 3 years ago

Kind reminder. :)

pvalena commented 3 years ago

Thanks! I'll look into it when I do all the reviews (which is right before I build new version for release).

pvalena commented 3 years ago

LGTM, thanks!

I'll build this on staging, and it will propagate in few hours: https://developer.stg.fedoraproject.org/tech.html

Enchufa2 commented 3 years ago

Great, thank you!