search

developer-portal / content

Content for the Fedora Developer Portal
https://developer.fedoraproject.org/
GNU General Public License v2.0
106 stars 250 forks source link

Virtualization #394

Closed gridhead closed 2 years ago

gridhead commented 3 years ago

Added 13 pages of goodness. :)

Fixes #392

gridhead commented 3 years ago

PLEASE DO NOT MERGE YET

The section icon is broken and I do not know how to add one.

01

gridhead commented 3 years ago

Hey @pvalena, could you please see if you can do something about the broken image?

jackorp commented 3 years ago

Hey @pvalena, could you please see if you can do something about the broken image?

Hi, could you please create an issue at developer-portal/website describing the command you ran and the output?

I ran 

$ docker run -it --rm -p4000:4000 -v "$PWD:/opt/developerportal/website/content:Z" quay.io/developer-portal/devel

successfully on this PR.

gridhead commented 3 years ago

Hi @jackorp,

Noting that the section that I am talking about here was newly introduced by me with this pull request. Here's the log.

podman run -it --rm -p 4000:4000 -v "$PWD:/opt/developerportal/website/content:Z" quay.io/developer-portal/devel
Configuration file: /opt/developerportal/website/_config.yml
            Source: /opt/developerportal/website
       Destination: /opt/developerportal/website/_site
 Incremental build: enabled
      Generating... 
       Git authors: Generating authors...
Traceback (most recent call last):
  File "/opt/developerportal/website/rss.py", line 23, in <module>
    feedparser._HTMLSanitizer.unacceptable_elements_with_end_tag.add('<div>')
AttributeError: module 'feedparser' has no attribute '_HTMLSanitizer'
                    done in 6.125 seconds.
 Auto-regeneration: enabled for '/opt/developerportal/website'
LiveReload address: http://0.0.0.0:35729
    Server address: http://0.0.0.0:4000/
  Server running... press ctrl-c to stop.
[2021-09-08 02:14:07] ERROR `/static/logo/virtualization.png' not found.
[2021-09-08 02:14:14] ERROR `/static/logo/virtualization.png' not found.
[2021-09-08 02:14:22] ERROR `/static/logo/virtualization.png' not found.

Here's a link to the ticket that I created there https://github.com/developer-portal/website/issues/121.

pvalena commented 3 years ago

What confuses me that virtualization is a general term, or a category, rather than a specific tool. Ideas?

CC: @hhorak

gridhead commented 3 years ago

@pvalena, I do seem to have covered at least three tools from the virtualization but maybe we should have a major section to itself.

pvalena commented 3 years ago

Actually, looking once more at it, it looks like it fits into tools, as it quite describe the low-level tools one might use, when working with virtualization.

Thanks once more!

gridhead commented 2 years ago

@pvalena,

Many thanks for the comprehensive review. I will line up the changes in a while and tag you back in when I am done making the suggested changes.

gridhead commented 2 years ago

@pvalena,

I made the requested changes. Do take a look. :)

jackorp commented 2 years ago

LGTM. Please also provide the source of the logo and license of the logo in the PR website#122, We can then merge both.

Thanks!

gridhead commented 2 years ago

@jackorp, https://github.com/developer-portal/website/pull/122 is now merged.

Please see if this PR can be merged now.

jackorp commented 2 years ago

LGTM, let's merge it.

pvalena commented 2 years ago

@t0xic0der Thanks for the good work!

Let's polish this in staging:

gridhead commented 2 years ago

Sure @pvalena. I am proofreading the contents right now. What else needs to be added?