search

developer-portal / content

Content for the Fedora Developer Portal
https://developer.fedoraproject.org/
GNU General Public License v2.0
106 stars 248 forks source link

vagrant-libvirt.md: QEMU / Session changes #419

Closed pvalena closed 2 years ago

pvalena commented 2 years ago

In Fedora, QEMU / Session is used. This is not documented properly. Advice users on what it is and how to revert in case it doesn't work for them.

pvalena commented 2 years ago

This change is LGTM. However, I'd like to have a more detailed "howto" for Fedora users to use this feature.

Please elaborate. What do you want me to do? What detail is missing? It's not supposed to be step-by-step guide. If you don't know how to use Vagrantfile, you need upstream docs (or do you know a better place?). If you do, you just add the directive.

pvalena commented 2 years ago

FTR: It's not a feature, it's a workaround for an issue we have only in Fedora, as noone else switched to QEMU Session yet for Vagrant (the better approach).

jackorp commented 2 years ago

This change is LGTM. However, I'd like to have a more detailed "howto" for Fedora users to use this feature.

Please elaborate. What do you want me to do? What detail is missing? It's not supposed to be step-by-step guide. If you don't know how to use Vagrantfile, you need upstream docs (or do you know a better place?). If you do, you just add the directive.

Hmm, I was probably tired and didn't read properly, sorry.

I'd say a "nice to have" would be to have the Vagrantfile option, that disables this feature, specified on this page? And if users would want to know more then they can refer to the change and docs.

jackorp commented 2 years ago

Thanks!

Let's merge this.