Closed tachoknight closed 2 years ago
Hi, thanks for the submission. I'll take a look.
I added Swift under the language section. It follows other languages in style so hopefully there aren't any issues. I'm not sure how to add a logo though.
Not sure if you are using some GitHub online editor.
With git, you just place the logo into the proper location and then git add <location>; git commit
.
Alternatively, create an issue on https://github.com/developer-portal/website/issues .
In both cases, please share the: source for the logo and the license which applies to the logo. If you raise just the issue with all the needed information (+ the image source), I can take care of creating the logo PR.
I found Apple's guidelines around the logo at https://developer.apple.com/swift/resources/ at the bottom of the page (it's a zip file that contains the guidelines as a PDF and the logo files themselves). The best "license" I've been able to find is the requirement to include the line: The Swift logo is a trademark of Apple Inc. Not a license per se, but the only reference to the logo with an actual license I've been able to find is https://en.wikipedia.org/wiki/File:Swift_logo.svg, which is the Apache license, similar to Swift itself.
Hopefully that helps.
On Mon, Jun 20, 2022 at 11:46 AM Jaroslav Prokop @.***> wrote:
Hi, thanks for the submission. I'll take a look.
I added Swift under the language section. It follows other languages in style so hopefully there aren't any issues. I'm not sure how to add a logo though.
Not sure if you are using some GitHub online editor. With git, you just place the logo into the proper location and then git add
; git commit. Alternatively, create an issue on https://github.com/developer-portal/website/issues . In both cases, please share the: source for the logo and the license which applies to the logo. If you raise just the issue with all the needed information (+ the image source), I can take care of creating the logo PR. — Reply to this email directly, view it on GitHub https://github.com/developer-portal/content/pull/441#issuecomment-1160660594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHWU3NVADZBJ2SX26S7PDVQCN7TANCNFSM5ZD5RQZA . You are receiving this because you authored the thread.Message ID: @.***>
I found Apple's guidelines around the logo at <...snip...>
Thanks! I'll recheck if Wikipedia has it correctly and create a PR at the website repo.
Thanks, I updated with file with your suggestions, much appreciated!
On Mon, Jun 20, 2022 at 12:17 PM Jaroslav Prokop @.***> wrote:
I found Apple's guidelines around the logo at <...snip...>
Thanks! I'll recheck if Wikipedia has it correctly and create a PR at the website repo.
— Reply to this email directly, view it on GitHub https://github.com/developer-portal/content/pull/441#issuecomment-1160684214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACHWU2BCK75EB27ON42CDDVQCRT3ANCNFSM5ZD5RQZA . You are receiving this because you authored the thread.Message ID: @.***>
Hi, were you able to check if my changes are okay?
Hi, thanks for pinging me :), sorry I meant to get to this PR sooner.
Yes, the PR is OK, I'll merge it. Thanks!
Hello-
I added Swift under the language section. It follows other languages in style so hopefully there aren't any issues. I'm not sure how to add a logo though.