search

developer-portal / content

Content for the Fedora Developer Portal
https://developer.fedoraproject.org/
GNU General Public License v2.0
107 stars 253 forks source link

Update instructions in ruby-installation.md #482

Closed GoodMirek closed 1 year ago

GoodMirek commented 1 year ago

For Fedora 38, also package perl-FindBin is needed to successfully install ruby with rbenv.

Also, updating the rbenv example to ruby 2.7.8 Ruby 2.7.8 is the latest and last version of ruby major version 2. Ruby 2 is now end of life.

jackorp commented 1 year ago

Thanks for the contribution. I have a PR that addresses the outdatedness of Ruby pages:

https://github.com/developer-portal/content/pull/478

It includes pretty much what you have suggested. I went with Ruby 3.0, as Ruby 2.7 went unsupported by upstream with the update to 2.7.8.

Would you mind reviewing that? Also thanks for noticing that perl dependency.

GoodMirek commented 1 year ago

Jarek,

Your change is huge and I cannot review all of the details now.

Can we go step by step and merge smaller parts?

Also, seeing that there are old approved PR's, which nobody merged, I am not sure if it is worth spending extra effort there.

Mirek Svoboda

On Mon, 17 Jul 2023 at 14:36, Jarek Prokop @.***> wrote:

Thanks for the contribution. I have a PR that addresses the outdatedness of Ruby pages:

478 https://github.com/developer-portal/content/pull/478

It includes pretty much what you have suggested. I went with Ruby 3.0, as Ruby 2.7 went unsupported by upstream with the update to 2.7.8.

Would you mind reviewing that? Also thanks for noticing that perl dependency.

— Reply to this email directly, view it on GitHub https://github.com/developer-portal/content/pull/482#issuecomment-1638047684, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3RMNEGZXSS3APXJ5DTV6TXQUWVTANCNFSM6AAAAAA2M3ZIXE . You are receiving this because you authored the thread.Message ID: @.***>

jackorp commented 1 year ago

Also, seeing that there are old approved PR's, which nobody merged, I am not sure if it is worth spending extra effort there.

I wanted to merge it, but then when retrying fresh rbenv install on a fresh VM, I bumped into the Perl dep and haven't had time to investigate further.

Otherwise there is some housekeeping due for the PRs for some time now.

jackorp commented 1 year ago

Thanks!

Closing as #478 includes these changes.