search

developer-portal / content

Content for the Fedora Developer Portal
https://developer.fedoraproject.org/
GNU General Public License v2.0
107 stars 253 forks source link

Add Fedora Specifc Notes For Golang Page #487

Closed buckaroogeek closed 1 year ago

buckaroogeek commented 1 year ago

This PR adds notes on Fedora specific changes to the standard Go language installation.

jwflory commented 1 year ago

Hi @pvalena, @hroncok, et al. Is there a process or procedure for getting Developer Portal PRs reviewed? @buckaroogeek asked for help here in the Fedora Documentation channel on getting this reviewed, but this site is not under maintenance by the Docs Team. I am wondering how we can help him get his changes reviewed. Thanks!

jackorp commented 1 year ago

@jwflory @buckaroogeek Hi, sorry this had flown under the radar.

Basically, reviews can be from community or by one of the maintainers that has the time (which didn't happen here).

It'd probably be a bit nicer to have more official process, or at least a few mandatory points to ack, to show that those things were reviewed. (This is more of a self-note, maybe github review template if that option exists?)

If anyone from the Fedora doc team or any person that can validate the technical side and general writing in a PR acks the PR and tags someone with merge rights, that sounds good enough to me at the moment. I generally go through open PR before release.

If anyone wants to review, I'd be more than happy to merge anything that is confirmed to adhere to the section 2 of the Fedora Developer Portal contributing guide. Especially the formatting outlined in https://developer-portal.github.io/contributing/write-introduction.html and the writing style outlined here https://developer-portal.github.io/contributing/write-general-writing-hints.html

buckaroogeek commented 1 year ago

@jackorp - Thank you. I posted a note in the golang matrix channel requesting a technical review. I will review the contributors info above and make updates as needed on style and formatting.

gotmax23 commented 1 year ago

/cc @alexsaezm who maintains golang in Fedora in case he has anything to add.

gotmax23 commented 1 year ago

It would also be a good idea to remove the merge commit in the PR. I'm not sure why that needs to be there.

gotmax23 commented 1 year ago

Other than that, this looks pretty good. Thanks for working on it!

buckaroogeek commented 1 year ago

It would also be a good idea to remove the merge commit in the PR. I'm not sure why that needs to be there.

Almost certainly my error.

buckaroogeek commented 1 year ago

@jackorp - I defer to your guidance on next step. I can submit a (revised) PR with the change recommended above by @gotmax23 or this PR could be merged and I can amend later.

jackorp commented 1 year ago

@buckaroogeek thanks for the quick changes :) We have a /cc that seem it would be good to hear back from on the topic.

The current state seems good to me, I think it is mergeable right now, let's wait a bit for the CC. I'd say merging it around next Tuesday sounds good. So you can amend it until then or wait until it is merged and then amend.

I'll make next round of release of the content around the 20th September (give or take around a week) to get back on some regular release track, so there is no big hurry.

Thanks!

jackorp commented 1 year ago

As promised. Current page is LGTM, let's merge.

Future amendments can be done in separate PRs.

buckaroogeek commented 1 year ago

Thank you!