developer-portal / website

Jekyll templates, CSS styles and images for the Fedora Developer Portal.
https://developer.fedoraproject.org/
GNU General Public License v2.0
40 stars 58 forks source link

Set logo max-width #127

Open pvalena opened 2 years ago

pvalena commented 2 years ago

E.g. https://developer.stg.fedoraproject.org/tech.html

The Redis logo f.e..

jackorp commented 2 years ago

Max width sounds like a good idea it would provide consistency in the logos.

However, note that the Redis logo has writing making the whole text shift more to the right, Having max-width would probably result in the logo getting much smaller... (AFAICT it's 300x100 -- 3:1 ratio of width to height, if it will get scaled it will look overall smaller than it should IMHO)

dknight commented 2 years ago

Agree with @jackorp Some logos have different dimensions and some of them have too much empty space inside image file, I put max-width: 100px some logos looked really bad and there is problem with alignment as well. Only solutions to "redraw" all logos in one style in graphical editor. max-width is not a solution at current state.