developer-portal / website

Jekyll templates, CSS styles and images for the Fedora Developer Portal.
https://developer.fedoraproject.org/
GNU General Public License v2.0
40 stars 58 forks source link

*sass: Added basic table style. #60

Closed RheaAyase closed 6 years ago

RheaAyase commented 6 years ago

I would add this (slightly modified Q&D copypasta) as basic style to hopefully make the tables look a bit more reasonable in short term, with later discussion about adding some .properties to easily differentiate between different styles, with a note in the contributing docs.

Example styles: https://github.com/RheaAyase/jekyll-rhea/blob/master/_sass/components/_global.scss#L40

Can be seen used in my blog as centered and striped with this .md source:

{: .centered .striped}
| Camber | Ratio | Effective top speed |
|---|---|---|
| 28 | 2.80 | 33.6 km/h |
| 30 | 3.00 | 36.0 km/h |
RheaAyase commented 6 years ago

(+cc @SpyTec - will be working with me on this one)

RheaAyase commented 6 years ago

Added the styles and documentation in developer-portal.github.io/pull/3

pvalena commented 6 years ago

Well, I do not know SCSS, but we can check how it looks.

Thanks!

RheaAyase commented 6 years ago

Yup, please let me know when it's on staging so we can check and fix whatever may or may not pop up :) I've updated the dotnet page so that can be used as a test case as well...

pvalena commented 6 years ago

Sorry, it seems our CI server is down(TBFixed on Mon).

All changes will be on our Staging instance just few hours (or a day) prior to release, so it's better to check our CI instance (fedorainfracloud), which should be generated after every merge. Best way to deal with this is IMHO running your local FDP instance using docker or vagrant :).

pvalena commented 6 years ago

Have you actually tested this? I am unable to build it:

Undefined mixin 'transition'. on line 235
pvalena commented 6 years ago
$ jekyll build
Configuration file: /home/vagrant/Work/RH/deploy/FDP/website/_config.yml
            Source: /home/vagrant/Work/RH/deploy/FDP/website
       Destination: /home/vagrant/Work/RH/deploy/FDP/website/_site
 Incremental build: disabled. Enable with --incremental
      Generating...
              Lunr: Creating search index...
              Lunr: Index ready (lunr.js v0.7.2)
    Liquid Warning: Liquid syntax error (line 241): [:dot, "."] is not a valid expression in "{{ .NetworkSettings.IPAddress }}" in content/tools/docker/compose.md
  Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/main.scss':
                    Undefined mixin 'transition'. on line 235
jekyll 3.4.4 | Error:  Undefined mixin 'transition'. on line 235
pvalena commented 6 years ago

Fully updated gems make no difference.

RheaAyase commented 6 years ago

It's missing libraries.