Closed RheaAyase closed 6 years ago
(+cc @SpyTec - will be working with me on this one)
Added the styles and documentation in developer-portal.github.io/pull/3
Well, I do not know SCSS, but we can check how it looks.
Thanks!
Yup, please let me know when it's on staging so we can check and fix whatever may or may not pop up :) I've updated the dotnet page so that can be used as a test case as well...
Sorry, it seems our CI server is down(TBFixed on Mon).
All changes will be on our Staging instance just few hours (or a day) prior to release, so it's better to check our CI instance (fedorainfracloud), which should be generated after every merge. Best way to deal with this is IMHO running your local FDP instance using docker or vagrant :).
Have you actually tested this? I am unable to build it:
Undefined mixin 'transition'. on line 235
$ jekyll build
Configuration file: /home/vagrant/Work/RH/deploy/FDP/website/_config.yml
Source: /home/vagrant/Work/RH/deploy/FDP/website
Destination: /home/vagrant/Work/RH/deploy/FDP/website/_site
Incremental build: disabled. Enable with --incremental
Generating...
Lunr: Creating search index...
Lunr: Index ready (lunr.js v0.7.2)
Liquid Warning: Liquid syntax error (line 241): [:dot, "."] is not a valid expression in "{{ .NetworkSettings.IPAddress }}" in content/tools/docker/compose.md
Conversion error: Jekyll::Converters::Scss encountered an error while converting 'css/main.scss':
Undefined mixin 'transition'. on line 235
jekyll 3.4.4 | Error: Undefined mixin 'transition'. on line 235
Fully updated gems make no difference.
It's missing libraries.
I would add this (slightly modified Q&D copypasta) as basic style to hopefully make the tables look a bit more reasonable in short term, with later discussion about adding some
.properties
to easily differentiate between different styles, with a note in the contributing docs.Example styles: https://github.com/RheaAyase/jekyll-rhea/blob/master/_sass/components/_global.scss#L40
Can be seen used in my blog as centered and striped with this .md source: