search

developer-student-club-thapar / DSC-WebDev-Task

2 stars 15 forks source link

there is some issue going on with some of the icons, they are not showing up. fix it #15

Closed okieLoki closed 1 year ago

arnavgupta00 commented 1 year ago

Icon issue fixed Import all assets.

import locationIcon from './assets/images/location-icon.svg';
import websiteIcon from './assets/images/website-icon.svg';
import twitterIcon from './assets/images/twitter-icon.svg';
import companyIcon from './assets/images/company-icon.svg';

Then replace img src with Dynamic imports:

<div className="bottom-icons">
   <img src={importName} />
</div>

Instead of importName put Dynamic Name.

madhavkapila commented 1 year ago

Please assign me this task

okieLoki commented 1 year ago

Assigned @SmartKapila

madhavkapila commented 1 year ago

Can you please advise a good website to get free svg images as I want to replace twitter svg with current logo of twitter in the src folder

madhavkapila commented 1 year ago

Solved the issue https://github.com/developer-student-club-thapar/DSC-WebDev-Task/pull/26#issue-1966705973 and created pull request #26 Please merge that into main repository.

okieLoki commented 1 year ago

Can you please advise a good website to get free svg images as I want to replace twitter svg with current logo of twitter in the src folder

use react icons (it almost every icon you would want)