search

developer-student-club-thapar / DSC-WebDev-Task

2 stars 15 forks source link

I committed this to solve issue 15 in the GDSC's repository DSC-WebDe… #26

Closed madhavkapila closed 1 year ago

madhavkapila commented 1 year ago

I committed this to solve issue #15 in GDSC repository DSC-WebDev-Task where icons were not appearing on the main page after searching for GitHub profile Firstly here I created a svg file by browsing the code over net and changing height and width to required ones to display new twitter logo X in place of old twitter birdie logo's svg already present in the repository Then I imported various svg files in the App.js file and used their dynamic link in the href attributes of respective img tags. I was able to do so as I observed that the main DSC logo is appearing so wht is difference between its and icons codes and found icons' img tags to be empty and that's why nothing was appearing there. I have attached some screenshots for reference. Screenshot from 2023-10-28 23-46-29 Screenshot from 2023-10-28 23-47-13 Screenshot from 2023-10-28 23-47-31 Screenshot from 2023-10-28 23-47-39

okieLoki commented 1 year ago

good work @SmartKapila :zap:

madhavkapila commented 1 year ago

Thank you @okieLoki