search

developer-student-club-thapar / mobile-app

Repository containing official Flutter based app for DSC TIET
MIT License
12 stars 11 forks source link

Add network check at the loading screeen #20

Closed ramyak-mehra closed 4 years ago

ramyak-mehra commented 4 years ago

Add some kind of internet checking at the loading screen. If the network is not available inform the user and display cached data Also, do error check while calling the backend API

rrkas commented 4 years ago

I can implement network check. Please assign me this issue.

rrkas commented 4 years ago

can you please tell which screen do you mean by loading screen.

rrkas commented 4 years ago

../../Documents/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:88:26: Error: Type 'DiagnosticableMixin' not found. class PictureStream with DiagnosticableMixin { ^^^^^^^^^^^^^^^^^^^ ../../Documents/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:192:44: Error: Type 'DiagnosticableMixin' not found. abstract class PictureStreamCompleter with DiagnosticableMixin { ^^^^^^^^^^^^^^^^^^^ ../../Documents/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:88:7: Error: The type 'DiagnosticableMixin' can't be mixed in. class PictureStream with DiagnosticableMixin { ^ ../../Documents/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:192:16: Error: The type 'DiagnosticableMixin' can't be mixed in. abstract class PictureStreamCompleter with DiagnosticableMixin { ^ ../../Documents/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:167:11: Error: Superclass has no method named 'debugFillProperties'. super.debugFillProperties(properties); ^^^^^^^^^^^^^^^^^^^ ../../Documents/Development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_svg-0.17.4/lib/src/picture_stream.dart:171:30: Error: The method 'toStringShort' isn't defined for the class 'PictureStreamCompleter'.

FAILURE: Build failed with an exception.

The project uses libraries that contain errors.

ramyak-mehra commented 4 years ago

@rrkas I have updated the libraries. The newer version of flutter had some breaking changes you can pull the latest changes.

rrkas commented 4 years ago

@ramyak-mehra please tell in which screen/page i have to implement the network check

ramyak-mehra commented 4 years ago

@ramyak-mehra please tell in which screen/page i have to implement the network check

I guess at the home page it would be a good idea to check internet connection and everywhere else we can do good error handling. What do you think?

rrkas commented 4 years ago

Ok. I'm on it

rrkas commented 4 years ago

I upgraded the flutter sdk to 1.23 Still SVG plugin was showing error. I then tried removing the plugin and its usage in project and tried to run. Then, this error shows. I checked, google-services.json file was missing in project/app directory. Please look into the matter.

FAILURE: Build failed with an exception.

ramyak-mehra commented 4 years ago

Checkout out the readme for setting up the project

rrkas commented 4 years ago

oh. ok. got it.

rrkas commented 4 years ago

please see pull request #21 there is conflict in pubspec.yaml & pubspec.lock files, but the internet check functionality is working fine

Bhupendrapt5 commented 4 years ago

Is this issue still on? if yes, can I work on it?

ramyak-mehra commented 4 years ago

Is this issue still on? if yes, can I work on it?

I was a bit busy to update. This has been resolved i am closing it, there are some more issues you can check or if you find any you can also post.