search

developer-stylechain / gulp-stylelint

Gulp plugin for running Stylelint results through various reporters.
MIT License
14 stars 5 forks source link

Allow Node 12+ Fixes #1 #2

Closed onigoetz closed 2 years ago

onigoetz commented 2 years ago

Hi,

I'd be happy to use your fork but the forced dependency on Node 15+ makes it difficult to use.

This allows Node 12+ and adds the versions on Travis CI as well

martin-badin commented 2 years ago

@ronilaukkarinen Could you merge this one?

ronilaukkarinen commented 2 years ago

@onigoetz @martin-badin Sorry, completely missed this! Can you elaborate on why should Node get downgraded? If I recall correctly many of the packages I use are dependent on Node 15+ and that's why it's here in the first place.

Wouldn't it be easier to just upgrade Node? Node 12 was released two years ago (2019) after all.

onigoetz commented 2 years ago

Hi,

Node 12 is still supported until april 2022 : https://nodejs.org/en/about/releases/ And migrating from one version to another in a company setting is not an easy task, jumping many versions ahead is quite complicated.

Also, Node 15 mentioned here is already unsupported as odd-numbered versions are supported only for 6 months

martin-badin commented 2 years ago

sorry but I am using a few dependencies and I want to upgrade the node at least to version 14 but this package is a blocker to me. I think this package should support the same supported versions as the original package. Node 12 is still supported until April 2022 but the version could be omitted. Therefore I think this package should support at least version 14 and above.

martin-badin commented 2 years ago

@ronilaukkarinen any update about this?

ronilaukkarinen commented 2 years ago

@martin-badin Sorry, I'm currently overbooked. I'll make time.

And migrating from one version to another in a company setting is not an easy task

Yeah, our company uses Node 15.

I'll test the merge in our workflow tomorrow and see if there's a chance without bigger conflicts with other dependencies.

ronilaukkarinen commented 2 years ago

@martin-badin @onigoetz The PR is now merged. Sorry for it taking so long, I'll be quicker about these next time around.

onigoetz commented 2 years ago

No worries, we all have lives outside GitHub :)

Thanks for the merge