search

developerdizzle / react-virtual-list

Super simple virtualized list React component
http://developerdizzle.github.io/react-virtual-list/
MIT License
617 stars 71 forks source link

fixed call to getViewBox and getItems #29

Closed davearata closed 8 years ago

davearata commented 8 years ago

Currently the call to this.viewBox will return a function instead of properly calling _getViewBox and the call to getItems in getVirtualState does not match order of parameters

developerdizzle commented 8 years ago

Yikes, nice catch! Unfortunately the tests are failing because the order of VirtualList.getItems arguments changed. Do you think you can fix that?

davearata commented 8 years ago

good call to fix tests. i didn't realize when i first ran the tests on my local they run from the built version of code in the dist folder. Changed my fix to just reorder the arguments when you call getItems and not the actual function definition.

developerdizzle commented 8 years ago

Hey @davearata, I actually ended up fixing this in ebc2f5045152af348c84f6f9f77dd08935144c41