developerforce / Force.com-Toolkit-for-PHP

Other
262 stars 215 forks source link

Numerous code and doc issues #45

Open aikar opened 9 years ago

aikar commented 9 years ago

Hello, I finally got around to updating our toolkit version as I got tired of the issues with the PHPDoc's of the old version I was using and wanted to get us up to date.

I see many of the issues have been fixed, but there are still glaring issues with the code that any good IDE identifies immediately!

There are a few methods like partner client sendSingleEmail that use uninitialized variables like so:

$arg->messages = $messages;

$arg was never created... And due to the questionable behavior of PHP, the code likely 'works', but is still wrong.

Many doc blocks also miss $ like so:

So to clean up the code, please open the code base in an IDE and fix the issues inspections are alerting on where possible (Sadly the use of relying on SoapClient for Class generation is going to result in many unknown classes)

But overall glad to see the docs mostly right now.