search

developerforce / LightningContainerExamples

67 stars 42 forks source link

fixes W-5018462: LCC in managed packages #21

Closed kfmartin closed 5 years ago

kfmartin commented 5 years ago

W-5018462 LCC fails to load embedded resources when installed via package https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B0000004xxxYIAQ/view

Fixed an issue where some of the samples hardcoded the /lcc path into their PUBLIC_URL. That impacts the links that landing page has to embedded resources (css,js). Works fine until LCC resource is installed via a managed package. In which case the URL needs to include the packages namespace.

Solution is to use relative paths. The LCC component will include namespace in URL as expected and if relative paths are used for embedded resources, then it works fine.

salesforce-cla[bot] commented 5 years ago

Thanks for the contribution! It looks like @kfmartin is an internal user so signing the CLA is not required. However, we need to confirm this.

kfmartin commented 5 years ago

@dougdew Neither Mike nor myself have permission to merge to this repo. We noticed you've merged changes in the past and wonder if you could merge this fix for us.

dougdew commented 5 years ago

@mpsenn @kfmartin It seems that I cannot merge the PR until the CLA has been signed.

Also, I would people to this repo, but lack the permission to do so. I recommend contacting Dave Carroll. He's the person who created this repo and has the permission to add more people.

kfmartin commented 5 years ago

Thx Doug. @dcarroll please add @mpsenn and myself as contributors to this repo.