search

developerforce / gif-booth

Add animated GIFs and Family Photo to your virtual events
Creative Commons Zero v1.0 Universal
3 stars 9 forks source link

Remove requirement for `AWS_BUCKET_URL` or `BUCKETEER_BUCKET_URL` environment variable #2

Closed crcastle closed 3 years ago

crcastle commented 4 years ago

Bucketeer does not create or populate this environment variable, and its value can be constructed using the BUCKETEER_BUCKET_NAME or AWS_BUCKET_NAME environment variable.

So config.js can probably be changed like this:

AWS_BUCKET_URL: `https://${process.env.BUCKETEER_BUCKET_NAME || process.env.AWS_BUCKET_NAME}.s3.amazonaws.com`
vishalol commented 3 years ago

@crcastle I would Iike to work on this. Can you please assign it to me

crcastle commented 3 years ago

Thank you @VishalCR7 ! Let me know if you have any questions. Please open a Pull Request when you're ready for us to review and merge your code.