developerforce / gif-booth

Add animated GIFs and Family Photo to your virtual events
Creative Commons Zero v1.0 Universal
3 stars 9 forks source link

User-provided GIF breaks group photo creation #46

Open crcastle opened 3 years ago

crcastle commented 3 years ago

When a user uploads a GIF instead of recording one, the group photo creation fails silently.

Steps to reproduce

Upload the GIF below to a deploy and also record a GIF the regular way. Then create a group photo with curl -X POST http://localhost:3001/createGroupPhoto. See error in log from that POST request. It will look something like this. Unfortunately I cannot figure out how to get a stack trace, but I believe the error comes from these lines of code -- specifically the composite() function call.

[Error: VipsImage: memory area too small --- should be 480000 bytes, you passed 360000
]

public_gifs_greeting-1604076477783