developersalliance / module-table-rates

Magento 2 Module for managing shipping table rates
Other
45 stars 7 forks source link

Failed install for Magento 2.4.5 #1

Closed 7LlantasManager closed 1 year ago

7LlantasManager commented 1 year ago

In the process of upgrade class, sudo php bin/magento se:up fails with this error:

Errors during compilation: DevAll\TableRates\Ui\Component\FormDataProvider Incompatible argument type: Required type: string. Actual type: \DevAll\TableRates\Ui\Component\name; File: /bitnami/magento/vendor/developersalliance/module-table-rates/Ui/Component/FormDataProvider.php

Total Errors Count: 1

davidtabat commented 1 year ago

@7LlantasManager I am setting up clean magento 2.4.5 instance to replicate the issue, will let you know when there will be updates.

davidtabat commented 1 year ago

issue confirmed, fix will be released in several minutes - thank you for the feedback!!

7LlantasManager commented 1 year ago

Thanks for your work, this module is fully functionally.

davidtabat commented 1 year ago

Released version 1.0.3 . It should be good now.

7LlantasManager commented 1 year ago

I'm test now

7LlantasManager commented 1 year ago

Installs works perfect! Nice Work. But I'm open the module and shows that:

Not registered handle tablerates_view_grid_data_source

I'm have already registered some shipping rates. But don't show.

davidtabat commented 1 year ago

I didn't manage to replicate the bug. if you are in production mode - also run setup:di:compile I realized the new version with the updated di.xml, (on some systems new line in the argument name value doesn't work so I remove the new line, so it could be that this was the cause for u as well)

davidtabat commented 1 year ago

Let me know if this fixed the issue or not.

7LlantasManager commented 1 year ago

It works!. Thank you.

davidtabat commented 1 year ago

You are welcome, Thank you very much for the very first open issue - we appreciate your contribution.