Card number duplicated

[DannyFeliz]

If you scroll down too fast something happens with the position numbers and appear duplicates

[rmariuzzo]

Do you mean duplicate position number? Or duplicate card?

On Oct 19, 2017 04:09, "Danny Feliz" notifications@github.com wrote:

If you scroll down too fast something happens with the cards numbers and appear duplicates [image: image] https://user-images.githubusercontent.com/5460365/31759785-88877764-b480-11e7-99ed-292bf5e5ddb0.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/developersdo/opensource/issues/38, or mute the thread https://github.com/notifications/unsubscribe-auth/AAa2H6JpvvAxMqf7qQpY0ePwYW13AySOks5stwPKgaJpZM4P-2Uf .

[iCueto]

He means that the position numbers is duplicate... :)

[hectoraristy]

I think the problem is here:

https://github.com/developersdo/opensource/blob/master/src/client/components/repositories/popular/Popular.js#L32-L39

[rmariuzzo]

It was intentional. Popular repositories are sorted by stargazers. However, two or more repositories can have same amount of stargazers. That's the reason I'm giving the same position.

What do you all think?

[hectoraristy]

It's nice to have it in the same position but in that way we don't have a validation to create an unique position number. So my suggestion is to remove the card number and give priority to the search bar.

[mecm1993]

The cause of the weird behavior of issue #34 is because of the same amount of stargazers between repos. However, in my opinion this is a list of the most popular, trending or newest repos from our community.

Therefore, duplication of position should not be allowed, if there are two or more repos with the same amount of stargazers, then the amount of watchers or forks should come up to make the difference between positions.

[rmariuzzo]

@hekotoru the search in both the repos and devs is a must have. We have to creat an issue for that.

@mecm1993 I understand your point on the #34. Even if we use more fields we should deal properly with repos that can have the same popularity.

Personally, I think the same position number due to the same amount of stargazers can be confusing. With that I mind it would be better to use more fields as suggested by @mecm1993 and finally sitting by their repo name and done. What do you all think?

[rmariuzzo]

This will be handled at #40. I will close this.