search

developersu / ns-usbloader

Awoo Installer and GoldLeaf uploader of the NSPs (and other files), RCM payload injector, application for split/merge files.
GNU General Public License v3.0
1.77k stars 116 forks source link

Can trick into selecting a folder for transfer and not the ROMs inside it #129

Closed PKGaspi closed 1 year ago

PKGaspi commented 1 year ago

Describe the bug (mandatory) When the option to select folders instead of files is turned on, it's possible to have a folder selected for transfer if the name ends with *.nsp (and probably other extensions too).

Information about environment (mandatory):

Steps to reproduce Steps to reproduce the behavior:

  1. Go to settings
  2. Activate the option "Select folder with ROM files instead of selecting ROMs individually".
  3. Go back to main tab.
  4. Have a folder named "whatever.nsp" with .nsp files inside it.
  5. whatever.nsp will appear in the selected ROMs list, with a size of 0.0B. The files inside this folders do not appear in the list.

Expected behavior Folders should not be listed in the ROMs list, and the ROMs inside this folder should be instead.

Did you see this issue in previous versions? Don't know

Additional context It's possible that this happens with other installable file extensions as well.

developersu commented 1 year ago

Thank you for reporting!

developersu commented 1 year ago

Checked this. Actually it's fine. This needed for handling split-files, which are actually folders and ends on '.nsp', '.xci' etc. So leaving it as is. It's like, for instance, it you rename '.mp3' file to '.nsp' and add it it'll also appear in app.