Closed sushma1031 closed 10 months ago
Built without sensitive environment variables
Name | Link |
---|---|
Latest commit | 9c3254a740ad5a5cfd5758cc49cc1b20041c1028 |
Latest deploy log | https://app.netlify.com/sites/developertools-tech/deploys/653fc66f91e0110008f5fd28 |
Deploy Preview | https://deploy-preview-131--developertools-tech.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
p
element and increase the font size?I'll take care of the remaining changes.
@sushma1031 I'm not sure what you mean by "I think the swap button can fit on the left, which text field should I add it to?"? I mainly just wanted the swap button to not be below the other buttons for that field, does that make sense? Apologies for not being more clear.
The input text makes sense, that can stay as is.
Yes, the contrast text can be larger, the current size is perfectly fine, just the semantics of heading tags does not make sense for that.
Thank you!
I'm not sure what you mean by "I think the swap button can fit on the left, which text field should I add it to?"? I mainly just wanted the swap button to not be below the other buttons for that field, does that make sense? Apologies for not being more clear.
Oh, right, I understood what you mean. The swap button isn't actually part of the text field, its purpose is to allow the user to swap the background and foreground colors, so I thought placing it in between the fields would be appropriate.
Similar to this:
@sushma1031 I see what you mean, maybe it just needs a little more vertical margin to get it away from the other buttons on that field? Whichever you think is best.
Yes, I agree that a little more vertical margin would be better, I'll add the same.
"Normal Text", "Large Text", and "Graphical Objects and User Interface Components" headings should be
h3
s, noth5
s
@dlford I made the mentioned headings h3, and I think they look too large. Can we reduce the font size?
maybe it just needs a little more vertical margin to get it away from the other buttons on that field? Whichever you think is best.
Is this much vertical margin sufficient?
@sushma1031 that vertical margin looks good!
For the h3
s, yes please make them smaller, thank you!
@dlford I made the requested changes, let me know if there's anything else!
@sushma1031 looks great, thank you!
Type of Pull Request
Related Issue #s or links (if any): Fixes #96
Description of Changes
Added a text contrast checking tool in the
colors
page, similar to the website referenced in the issue. Added the required namespace and tests as well.