search

developertools-tech / developertools.tech

A collection of tools for developers served as a PWA
https://www.developertools.tech
MIT License
39 stars 45 forks source link

Sorting Tool #35

Closed TechSpiritSS closed 1 year ago

TechSpiritSS commented 2 years ago

Type of Pull Request

Related Issue #s or links (if any):

21

Description of Changes

Everything is working great and tested except for one bug. User is required to click sort twice in case of New Line separator to get the desired result. I'm not sure why this is happening but I wasn't able to resolve this bug.

netlify[bot] commented 2 years ago

Deploy Preview for developertools-tech ready!

Name Link
Latest commit 9bf29811876f5b62aecc13c1a4bd06068f61859a
Latest deploy log https://app.netlify.com/sites/developertools-tech/deploys/6341457e186e0800092e18df
Deploy Preview https://deploy-preview-35--developertools-tech.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dlford commented 2 years ago

@TechSpiritSS I'll look into that issue and get back to you, we can't merge as is unfortunately.

TechSpiritSS commented 2 years ago

:') well, that's fine, if you know the reason for the bug do let me know as well.

TechSpiritSS commented 2 years ago

I think it's better to change that into new issue as I might not be able to commit those changes as I am travelling for next two days.

dlford commented 2 years ago

I think it's better to change that into new issue as I might not be able to commit those changes as I am travelling for next two days.

No worries, just the UI fixes then please

dlford commented 2 years ago

@TechSpiritSS are you still wanting to work on this?

TechSpiritSS commented 2 years ago

Yes, I'll work on this, got some college stuff to deal with this week.

dlford commented 2 years ago

No worries, thank you!