Add worker-loader - Githubissues

developit / microbundle

📦 Zero-configuration bundler for tiny modules.

https://npm.im/microbundle

MIT License

8.06k stars 361 forks source link

Add worker-loader #815

Closed TimDaub closed 3 years ago

TimDaub commented 3 years ago

Fixes #814
Superseeds #757

Few comments

I tried rebasing on the latest master but I got confused about the package-lock.json file. I'd appreciate some help. I'm not sure how to solve all of this properly.
I ended up using https://github.com/surma/rollup-plugin-off-main-thread which @developit recommended in #757
I didn't put TypeScript support because I don't know TypeScript. I've made a note in the readme that it only works with JS builds for now. Maybe someone can add TS in a separate PR...

🤞🏼 that somehow this gets merged!

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: f155eee1982169735ce5ededdd370e0f014f01f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

TimDaub commented 3 years ago

@developit I addressed your comments. I'm not sure I'm capable of rebasing though. Last time I tried sketchy things happened in package-lock.json that I wasn't able to address. What now?

ForsakenHarmony commented 3 years ago

Last time I tried sketchy things happened in package-lock.json that I wasn't able to address.

You generally have to accept the remote one and then after create a new commit / amend a commit with a file you generated after by running npm install

developit commented 3 years ago

I'll try to get this rebased this week (I'm also terrible at it!).

This will need to go into a new breaking release (minor since microbundle is still pre-1.0), but I think that should be fine.

developit commented 3 years ago

Just wanted to mention I haven't forgotten about this PR, I just have been side-tracked rewriting Microbundle's filename inference.

developit commented 3 years ago

This was landed in #867! 🎉