fix: Corrects completion message to show the package's name, rather than the safe name

developit / microbundle

📦 Zero-configuration bundler for tiny modules.

https://npm.im/microbundle

MIT License

8.04k stars 362 forks source link

fix: Corrects completion message to show the package's name, rather than the safe name #895

Closed rschristian closed 2 years ago

rschristian commented 3 years ago

Corrects a minor annoyance

As far as I know there's no reason we need to display the safe name here, and (IMO) it's better if the displayed name is the package's actual name or (in the case of a missing "name" in the pkg.json) the directory name.

changeset-bot[bot] commented 3 years ago

🦋 Changeset detected

Latest commit: 67deaab9834d3e14a23b12d00aef142ccec1acd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------- | ----- | | microbundle | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

developit commented 2 years ago

Does this change the name for multi-entry?

rschristian commented 2 years ago

Not sure I understand. Mutli-entry shouldn't be impacted in any way to my knowledge, the only thing that changes is the name in the output message. Assuming a pkg with "name": "microbundle-foo":

Before: Output shown as `microbundleFoo`

After: Output shown as `microbundle-foo`

Just has been a minor annoyance I've had in packages with hyphenated names.