changeset-bot[bot]
commented
2 years ago 🦋 Changeset detected
Latest commit: 336a485490fb3e64196c449b027070c4ad2a39a1
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type | | ----------- | ----- | | microbundle | Patch |Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Intro
Hi 👋 , by way of introduction, I help maintain
rollup-plugin-typescript2and also formerly solo-maintained TSDX for ~1.5 years (the creator hasn't been involved in years and his abusiveness was central to me leaving OSS for over a year), so I'm very familiar with the internals ofmicrobundleas well.I was investigating https://github.com/ezolenko/rollup-plugin-typescript2/issues/295 and found that
microbundleis on an older version of rpt2, causing several issues in this repo.Summary
Upgrade rpt2 to v0.32.0 to fix various monorepo issues
Details
rpt2 v0.30.0 supports compiling files outside of the project directory with no additional configuration (e.g. of
rootDir) as it upgraded its dep of@rollup/pluginutilsto v4, which had a breaking change affectingcreateFilterin https://github.com/rollup/plugins/pull/517@rollup/pluginutilsallows transforming files outside of the project dirrpt2 v0.32.0 supports symlinks, such as with monorepos built w/ pnpm
previously, microbundle was using rpt2 v0.29.0, which is about ~1.5 years out-of-date
References
Testing
It doesn't look like
microbundle's fixtures support monorepos yet (would require setting up symlinks orpnpmetc), so as a result I didn't add a whole test suite for that which would've made this PR significantly more complex and involved in the internals of the testing set-up. Once I set-up an integration test for this in rpt2, I could contribute a similar fixture downstream here, but it may require a different CI workflow to not break the existing test set-up