search

developit / microbundle

📦 Zero-configuration bundler for tiny modules.
https://npm.im/microbundle
MIT License
8.03k stars 362 forks source link

fix: Incorrect transform with async/await (#565) #968

Closed PeterBurner closed 2 years ago

PeterBurner commented 2 years ago
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: be8c907010a88acd3ca8836462c4bc0532eb5233

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | microbundle | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

PeterBurner commented 2 years ago

Any idea if this is necessary? Looks like Yarn (v1, anyhow) will correctly resolve the newer version on a fresh install. Not sure if other tools do the same.

This might be true. However since the fixed bug in babel-plugin-transform-async-to-promises affects how code is transformed, an update might break things for some users. In my eyes this warrants a new microbundle version. Including a explicit warning in the release notes.

rschristian commented 2 years ago

an update might break things for some users

If it was breaking (I don't think it is), this should've been marked as a semver minor (as we're still in a 0-major), not a patch. But as microbundle used ^0.8.15, lock file permitting, this update could've happened at any point. It's not locked behind a new version.

Fair enough if that was the justification, a new microbundle version will force users to get this fix I suppose.