Open mmkal opened 2 years ago
Latest commit: 8b5295dd7b45bd8e5c379bb563065fdfedb03bc9
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Thanks so much for taking a first stab at this Misha!
We'll want to look into a way to configure SWC plugins somehow without directly involving microbundle. Does SWC offer some sort of .swcrc
config mechanism it'll just pick up when running over a codebase?
Looks like there is a .swcrc
, yes: https://swc.rs/docs/usage/core#options
@developit curious to get your thoughts on this!
Jason's on vacation right now so a response/review might be a bit.
- (maybe) rely on rollup-plugin-swc3 to emit typescript declaration files too. Might or might not be faster 🤷
@mmkal Have you used it for this purpose in the past? Any major issues/shortcomings you know of?
We use rollup-plugin-typescript2
which admittedly there are many problems with, so I'm curious if swc might be viable.
/bump
Hi! Was going to write this as a comment but I thought a functional PR would be a nicer way to make a proposal.
A cleaned up version of this could resolve #943 in a way that didn't involve either inflating microbundle's size or completely rewriting the whole library around SWC.
Basically, it looks for the
@swc/core
dependency, and if it's found, assumes that the user wants to useswc
instead of babel or typescript. But@swc/core
isn't a dependency of microbundle. Which means most users can just continue using microbundle as is and not be affected. People who want to try microbundle out with SWC just have to install@swc/core
which has the nice properties of being natural and intuitive for people who do want to use SWC, and unusual for anyone else.It does add
rollup-plugin-swc3
as a proper dependency of microbundle, because that's just a small javascript module, and it seems like the sort of thing microbundle should save users from having to worry about (whether they should userollup-plugin-swc
,rollup-plugin-swc2
orrollup-plugin-swc3
, and how to configure the chosen package).I tried on a small typescript project with no dependencies, with an output of about 4kb. With swc it took about 6s, without it took 21s (and using
--compress false
, timings were 3s vs 19s , see point 4 below).Some things that should be addressed before this PoC were to be shippable (I didn't attempt to do this because I am not very knowledgeable about microbundle, babel, or SWC):
@swc/core
installed for unrelated reasons to opt out (e.g.--swc false
)target: 'es2018'
fairly arbitrarily. It should also respect any existing swc config detected, if present.src/index.js
to make the diff easy to ready, but probably some refactoring should be done@swc/core
apeerDependency
withpeerDependenciesMeta.optional = true
If this goes well and people start using it, after a few months of the community helping flush out any issues, maybe something like the solution suggested by @developit in https://github.com/developit/microbundle/issues/943#issuecomment-1146963352 could be done with SWC. But the advantage of doing this way first is that we could likely do exactly the same thing with rollup-plugin-esbuild, and effectively support users with both. The community seems pretty evenly split between the two, and they're both an order of magnitude faster than typescript or babel.