developit / preact-css-transition-group

Apply CSS transitions when adding or removing Preact components/elements
62 stars 17 forks source link

Sync with react-addons-css-transition-group? #7

Open mauron85 opened 7 years ago

mauron85 commented 7 years ago

As far I understand preact-css-transition-group is based on react-addons-css-transition-group. I guess not the latest version.

I'm currently investigating issues similar to https://github.com/facebook/react/issues/1707. Not sure, maybe it's not problem of preact-css-transition-group at all. Anyway, it would be beneficial to know how merge is done and how often. So I have couple of questions regarding that.

When was last sync with react-addons-css-transition-group? Is there any procedure or how often is sync done? How can I get version react-adddon-css-transition-group that preact version is based on?

Is hard to compare by commit ids as code structure seems to be bit different to current version of react-addons-css-transition-group

developit commented 7 years ago

I think the two have diverged fairly significantly, so a sync seems difficult. The original was from React 0.14.3 I believe. I would prefer to replace this repo with a cleanroom implementation if I (or anyone!) can find the time.

mauron85 commented 7 years ago

I guess the main reason for existence of this module was that it wasn't distributed as separated module (but was bundled with react itself). But now there is separate module. So why we can just use it? Actually I've tried, but it didn't work.

I will probably take look on it, but it will be very helpful, if you can give me some insights, how is this different from https://www.npmjs.com/package/react-addons-transition-group. Just few words, not TLDRs :-)

developit commented 7 years ago

Nah - sadly, like all of the add-on "modules" that is just an alias into React's internals:

https://unpkg.com/react-addons-transition-group

mauron85 commented 7 years ago

Ouch didn't know that. I'm bit disappointed, but enlightened on the other hand. Now I understand motivation behind this module bit more. Thanks.

developit commented 7 years ago

That's exactly how I feel haha