Add Windows support. - Githubissues

developit / preact-redux-example

:repeat: Preact + Redux Example Project

https://preact-redux-example.surge.sh

199 stars 53 forks source link

Add Windows support. #3

Closed katopz closed 8 years ago

katopz commented 8 years ago

FYI

Windows didn't support ${PORT:-8080}
mkdir -p via windows will create undesired path -p
npm run env didn't work properly with && so cross-env is better choice here.

I try to made minimal change as possible, tested on both Windows 7sp1, MacOS ElCap. I you fine with this, I'll start to roll out this to other example. :)

developit commented 8 years ago

Thanks @katopz - looks good. Is there a way to keep that environment variable for PORT working? I'm basically unfamiliar with cmd, heh.

katopz commented 8 years ago

AFAIK, It has but it won't cross-platform and maybe not one liner. Maybe we can do something like "start_win" : "and-we-do-windows-stupid-cmd-here" instead and left "start" untouched for mac. :)

developit commented 8 years ago

Fine by me then!