search

developit / preact-redux

:loop: Preact integration for Redux (no shim needed!)
https://npm.im/preact-redux
MIT License
288 stars 27 forks source link

fix named exports for es6 bundles, update rollup deps #15

Closed ezekielchentnik closed 7 years ago

developit commented 7 years ago

Hey @ezekielchentnik - was just about to copy the rollup config from preact-compat and noticed this PR. I'm tempted to try out preact-compat's since it's just the one file (keeps things clean) - if I can't get that working this looks like the ticket.

ezekielchentnik commented 7 years ago

@developit sounds good, definitely cleaner

ezekielchentnik commented 7 years ago

also, I believe these rollup updates will fix a couple outstanding import issues, #14, #1 etc. multiple birds 1 stone :)

developit commented 7 years ago

totally - was pumped when I saw it's already done haha

developit commented 7 years ago

oooh - is this what I think it is? you're making my job too easy man haha

ezekielchentnik commented 7 years ago

it is, i've condensed my original rollup tweaks into 1 config (like preact-compat); although, I'm noticing bundle size increase :( - troubleshooting that

ezekielchentnik commented 7 years ago

uglify is not dropping as much with this change

developit commented 7 years ago

Hmm - might also be an upstream change in react-redux causing the size increase?

developit commented 7 years ago

@ezekielchentnik good call on proptypes, though we might need to do 2 modules there (to not trample the default exports for react imports)

ezekielchentnik commented 7 years ago

@developit what's needed to get this merged?

developit commented 7 years ago

Nothing! My GH inbox is doomed