developit / preact-redux

:loop: Preact integration for Redux (no shim needed!)
https://npm.im/preact-redux
MIT License
288 stars 27 forks source link

Update preact-redux.d.ts #22

Closed fend25 closed 6 years ago

fend25 commented 6 years ago

fixes error

There is such error with:

[at-loader] ./node_modules/preact-redux/src/preact-redux.d.ts:277:14
    TS2415: Class 'Provider' incorrectly extends base class 'Component<ProviderProps, {}>'.
  Types of property 'render' are incompatible.
    Type '(props: ProviderProps) => VNode' is not assignable to type '(props?: (ProviderProps & ComponentProps<this>) | undefined, state?: {} | undefined, context?: an...'.
      Types of parameters 'props' and 'props' are incompatible.
        Type '(ProviderProps & ComponentProps<this>) | undefined' is not assignable to type 'ProviderProps'.
          Type 'undefined' is not assignable to type 'ProviderProps'.
lucaspiller commented 6 years ago

For anyone feeling stuck until this is merged (even if I edit the typings locally, it'll fail on CI), I worked around it by:

notary commented 6 years ago

Hi guys. What with this pull-request? @arusanov @fend25

ameliemaia commented 6 years ago

Guys, can we please get this merged?

jahilldev commented 6 years ago

@developit When is this likely to be released? Would be nice to correctly type my connect instances. Thanks

developit commented 6 years ago

Releasing

jahilldev commented 6 years ago

@developit Can't see the new version in the releases list or published to NPM. Any news? Thanks

strootje commented 5 years ago

@developit Any news on that release?