search

developit / preact-redux

:loop: Preact integration for Redux (no shim needed!)
https://npm.im/preact-redux
MIT License
288 stars 26 forks source link

Error when using --strictNullChecks Typescript's compiler option #28

Open thenameisflic opened 6 years ago

thenameisflic commented 6 years ago

I created a simple project via preact-cli, added the typescript plugin, redux and preact-redux, but i got this error when running npm run start:

✖ ERROR [at-loader] ./node_modules/preact-redux/src/preact-redux.d.ts:278:5
    TS2416: Property 'render' in type 'Provider' is not assignable to the same property in base type 'Component<ProviderProps, {}>'.
  Type '(props: ProviderProps) => VNode' is not assignable to type '(props?: (ProviderProps & ComponentProps<this>) | undefined, state?: {} | undefined, context?: an...'.
    Types of parameters 'props' and 'props' are incompatible.
      Type '(ProviderProps & ComponentProps<this>) | undefined' is not assignable to type 'ProviderProps'.
        Type 'undefined' is not assignable to type 'ProviderProps'.
thenameisflic commented 6 years ago

As a workaround, i added my own preact-redux.d.ts and told typescript to ignore the module typings.

bestmike007 commented 6 years ago

It's fixed on master branch:

https://github.com/developit/preact-redux/blob/master/src/preact-redux.d.ts#L278

But not published yet:

https://github.com/developit/preact-redux/blob/2.0.3/src/preact-redux.d.ts#L278

@developit need a new package version with this fix.