search

developit / preact-redux

:loop: Preact integration for Redux (no shim needed!)
https://npm.im/preact-redux
MIT License
288 stars 27 forks source link

Creates new jsnext bundle #3

Closed yfr closed 7 years ago

yfr commented 7 years ago

@developit In the tests, I had to use the default import because the named imports for Provider does not work.

developit commented 7 years ago

Ah right, I don't think I had Webpack set up for that.

yfr commented 7 years ago

Webpack? This repo uses rollup right?

I would love to export the Provider and connect methods from redux as own exports. Do you know how to do that with rollup? We can just merge this if you like and i open another issue for that.

developit commented 7 years ago

Yeah the build is rollup, but Karma is set up to use webpack.

I opened a PR for the named exports thing. With the umd build it didn't matter much, but the result from esmodules is different. We can merge your PR first and then adjust to account for the named exports.

yfr commented 7 years ago

Cool, that's fine with me!

yfr commented 7 years ago

@developit can you have a look?

developit commented 7 years ago

@yfr Looks good! Now it'll run in Node 4+ :)