search

developit / preact-redux

:loop: Preact integration for Redux (no shim needed!)
https://npm.im/preact-redux
MIT License
288 stars 27 forks source link

(chore) Add support for preact x #48

Open cristianbote opened 4 years ago

cristianbote commented 4 years ago

This adds support for preact x but depends on this PR from preact https://github.com/preactjs/preact/pull/1901. After that's merged and released we could merge this one as well.

~Adds +3.71kB 😞 more than double it's current size~ ~Adds +0.89kB 😄 now we're talking~ Adds +0.98kB 🤔

cristianbote commented 4 years ago

This will fail until https://github.com/preactjs/preact/pull/1901 is merged

cristianbote commented 4 years ago

This is gonna be working when https://github.com/preactjs/preact/pull/1924 it's gonna get released

cristianbote commented 4 years ago

Also this updates the react-redux version and redux with the latest ones.

developit commented 4 years ago

Folks will be glad to have this working in X. One question still in my mind though: do we know why aliasing react:preact doesn't work, instead requiring all of compat? I'd really love to quantify that delta.

cristianbote commented 4 years ago

Hey @developit that's a great point! Unfortunately it seems that the build size increases if I would add the imports by hand and re-export them. 🤷‍♂

jahilldev commented 4 years ago

@cristianbote @marvinhagemeister Any ideas on when this might be released? Would really like to upgrade to Preact X.

Many thanks

cristianbote commented 4 years ago

@jhdevuk it's awaiting Jason's review. It's on his todo list 👍

adminy commented 2 years ago

Ok, well, what are the alternatives? Where to get Provider and connect from?