search

developit / undom

🍩 1kb minimally viable DOM Document implementation
https://npm.im/undom
MIT License
668 stars 25 forks source link

Missing returns for Node.{insertBefore, appendChild, replaceChild, removeChild} #15

Closed andyrj closed 6 years ago

andyrj commented 7 years ago

To match actual dom api these calls need to return the nodes added or removed.

https://developer.mozilla.org/en-US/docs/Web/API/Node/insertBefore https://developer.mozilla.org/en-US/docs/Web/API/Node/removeChild https://developer.mozilla.org/en-US/docs/Web/API/Node/appendChild https://developer.mozilla.org/en-US/docs/Web/API/Node/replaceChild

Was there a reason for leaving off these returns? Ran into this using undom with hyperapp.

zaceno commented 7 years ago

Bump! I'd love to see this merged and released soon!

andyrj commented 7 years ago

@developit Is there any chance this will be merged? I'd prefer to avoid publishing a fork to npm just for these return statements. :disappointed:

developit commented 6 years ago

Sorry about the super slow response! I'm merging.

zaceno commented 6 years ago

Thanks @developit !! 🎉

andyrj commented 6 years ago

@developit Thank you!